-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
feat: Add configurable response data storage for notifications (#6164) #6192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add configurable response data storage for notifications (#6164) #6192
Conversation
…lam#6164) - Add `response` column to heartbeat table to store HTTP response data - Add monitor configuration options: `saveResponse` (default: false) and `responseMaxLength` (default: 10240 bytes) - Response max length of 0 allows unlimited storage without truncation - Response data accessible in notification templates via `heartbeatJSON.response` - Add UI controls in monitor edit page with translations (EN, DE-DE, DE-CH) - Only saves response data when explicitly enabled to minimize database impact Resolves louislam#6164
b2551d2 to
d44ee3a
Compare
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks reasonable.
I am not sure if the max chars should be a constant setting. 🤔
I don't quite remember if adding something just to the heartbeat table works. => does the UptimeCalculator leave entries which have not yet been notifed for or how do these two systems interact?
Adding the stored values to the fronted (where it exists) would be going above and beyond. Not sure if you want to do this or if we should open a follow up issue for this
- Use i18n-t component to display template variable as formatted code - Refactor responseMaxLength using nullish coalescing operator - Update translation en.json for clarity
Hi @CommanderStorm,
|
912fdca to
7b0bb77
Compare
|
|
||
| <!-- HTTP / Keyword only --> | ||
| <template v-if="monitor.type === 'http' || monitor.type === 'keyword' || monitor.type === 'json-query' || monitor.type === 'grpc-keyword' "> | ||
| <template v-if="monitor.type === 'http' || monitor.type === 'keyword' || monitor.type === 'json-query'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the change to grpc-keyword is resolved/removed, we can merged.
GRPC does currently not log, but should have redirects.
|
(put it in 2.2 instead of 2.1 due to the grpc issue) |
responsecolumn to heartbeat table to store HTTP response datasaveResponse(default: false) andresponseMaxLength(default: 10240 bytes)heartbeatJSON.responseResolves #6164
❗ Important Announcements
Click here for more details:
🚫 Please Avoid Unnecessary Pinging of Maintainers
We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.
📋 Overview
🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes
When the save Response is activated:
When the save response is deactivated:

UPDOWNIf you need more information or context, feel free to contact me.