Skip to content

Conversation

@sebastiaanspeck
Copy link
Contributor

Could be used like a pre-release or for ease to not need to rebuild locally after a fix has been pushed to main

Could be used like a pre-release or for ease to not need to rebuild locally after a fix has been pushed to main
@louis-e
Copy link
Owner

louis-e commented Jan 3, 2025

Sounds like a good idea, however according to the ci-build.yml logic, will this also upload a new artifact each time a pull request CI starts running? :D

@sebastiaanspeck
Copy link
Contributor Author

Sounds like a good idea, however according to the ci-build.yml logic, will this also upload a new artifact each time a pull request CI starts running? :D

That's true.. we can add an if-statement I believe to check for the GH Action trigger

@sebastiaanspeck sebastiaanspeck changed the title Upload artifact after building Upload artifact after pushing to main Jan 3, 2025
@sh2kcs
Copy link
Contributor

sh2kcs commented Jan 23, 2025

pls @louis-e

@Oleg4260
Copy link
Contributor

This should be revived and merged into main. Looks like a good feature, since the main branch is getting a lot useful features and bugfixes, but many users aren't able to build the program from source and also it's too long to wait for a new release

@sebastiaanspeck
Copy link
Contributor Author

This should be revived and merged into main. Looks like a good feature, since the main branch is getting a lot useful features and bugfixes, but many users aren't able to build the program from source and also it's too long to wait for a new release

I have just merged main into this branch again. Haven’t tested if all targets are uploaded now. Feel free to check and add suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants