LoroWebsocketClient race condition fix in react strict mode#58
Open
mgrinshpon wants to merge 2 commits intoloro-dev:mainfrom
Open
LoroWebsocketClient race condition fix in react strict mode#58mgrinshpon wants to merge 2 commits intoloro-dev:mainfrom
mgrinshpon wants to merge 2 commits intoloro-dev:mainfrom
Conversation
…eact strict mode via unit test; fix the error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoroWebsocketClientwhen mounting in effect in react strict mode via unit testExplanation
In development, react has a thing called "strict mode" which mounts, then unmounts, then re-mounts all components.
sendJoinPayloadcallsvoid this.connect()as a fallback retry.connect()unconditionally setsshouldReconnect = true, which resurrects a client that was intentionally closed viaclose(). This manifests in React strict mode whereuseEffectcreates a client + joins a room, and the cleanup function callsclose()but a deferred microtask fromresolveAuth().then(sendJoinPayload)fires afterclose(), callingconnect()and creating a zombie WebSocket connection.A piece of sample code that would cause this fire is: