Refactor OverrideActivationModal to simplify duration handling - #740
Merged
Conversation
…ke duration settings available for all overrides
…finite activation
marionbarker
approved these changes
Aug 16, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve from code review and test.
- tested Loop enables Override duration to be change regardless of saved value on Loop phone
- tested Trio is not modified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the timing restriction for remote override activation and allows users to set a custom duration for every override preset, including presets that already have a predefined duration.
What changed
Enabled duration controls for all override presets in the activation modal.
Kept sensible defaults:
Presets with fixed durations default to their preset duration.
Indefinite presets default to “Enable indefinitely”.
Updated activation behavior so the submitted duration always follows user choice:
“Enable indefinitely” ON sends an indefinite override.
“Enable indefinitely” OFF sends the selected slider duration.
Why
Previously, presets with predefined durations could not be adjusted at activation time. This prevented quick context-based adjustments. The new behavior gives users consistent, flexible control without losing preset defaults.
UX impact
More consistent activation flow across all presets.
Faster adjustments for real-world situations.
Backward-friendly behavior through preset-based defaults.
fixes #730