Skip to content

Fix/windows batch percent paths #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imMamdouhaboammar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/windows batch percent paths #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f2b85
test(cron): pin literal percent paths in cmd wrappers
imMamdouhaboammar Aug 7, 2026
3d41ad0
fix(cron): escape percent signs in cmd wrapper literals
imMamdouhaboammar Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/loop-js/src/cli/cron/wrapper.percent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { expect, test } from "bun:test"
import { cmdWrapper } from "./wrapper.ts"

const AT = 1_700_000_000

test("cmd wrapper escapes literal percent signs in generated path and argv literals", () => {
const text = cmdWrapper(
{ id: "abc123", dir: "C:\\work\\%TEMP%\\proj", until: { settled: false } },
["C:\\tools\\100%\\bun.exe", "C:\\cli\\loop%20cli.ts"],
AT,
)

expect(text).toContain('cd /d "C:\\work\\%%TEMP%%\\proj" || exit /b 1')
expect(text).toContain('"C:\\tools\\100%%\\bun.exe" "C:\\cli\\loop%%20cli.ts" "run"')
expect(text).toContain('>> "C:\\work\\%%TEMP%%\\proj\\.loop\\cron\\abc123.log" 2>&1')
expect(text).not.toContain('"C:\\work\\%TEMP%\\proj"')
})
4 changes: 3 additions & 1 deletion packages/loop-js/src/cli/cron/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ exit $rc
export function cmdWrapper(entry: Pick<Entry, "id" | "dir" | "until">, cli: string[], installedAt: number): string {
const { id, dir, until } = entry
const log = file(dir, id, "\\", ".log")
const q = (s: string) => `"${s}"`
// `%...%` and `%0`-`%9` are substitutions even inside quotes in batch files. `%%` emits a
// literal percent sign, so filesystem/argv strings survive paths such as `C:\work\%TEMP%`.
const q = (s: string) => `"${s.replaceAll("%", "%%")}"`
const argv = (sub: string[]) => [...cli, ...sub].map(q).join(" ")
const run = `${argv(["run"])} >> ${q(log)} 2>&1`
const remove = `${argv(["cron", "remove", id])} >> ${q(log)} 2>&1`
Expand Down