fix(ci): replace msbuild longbridge.sln with cmake --build for Windows#541
Merged
Conversation
windows-latest upgraded to VS2026 (MSBuild 18.6.3) which generates a different .sln filename. Using cmake --build avoids the hardcoded filename and works with any generator. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
cargo install cargo-make fails intermittently due to crates.io network issues (HTTP2 framing errors). taiki-e/install-action downloads pre-built binaries from GitHub Releases, which is faster and more reliable. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
windows-latestrunner was upgraded to VS2026 (MSBuild 18.6.3), which generates a different.slnfilename than VS2022. The Makefile.toml hadlongbridge.slnhardcoded, causing:Fix
Replace
msbuild longbridge.slnwithcmake --build .inc/Makefile.tomlandcpp/Makefile.toml.cmake --builddelegates to the underlying build system and doesn't depend on the.slnfilename.Before:
After:
This change is backward-compatible with VS2022 and works with any cmake generator.