Add missing @Override annotations#1014
Open
msbarry wants to merge 3 commits intolocationtech:masterfrom
Open
Conversation
Signed-off-by: Mike Barry <msb5014@gmail.com>
msbarry
force-pushed
the
override-annotations
branch
from
9cc4e94 to
5fa638c
Compare
Signed-off-by: Mike Barry <msb5014@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to add generics to some of the spatial index classes (see #1012 (comment)) and to make that refactor a bit safer, it would help to have
@Overrideannotations on any method that overrides a superclass method to generate a compile error when there's a type mismatch between the method in parent which may have generics mid-refactor and child class which may not.This PR runs Intellij's "Add missing
@Overrideannotations" automated fix to all of the java files in the project.If we wanted to we could also add the "MissingOverride" checkstyle check to enforce this?