Open
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
Member
Author
|
Cc @carole-lavillonniere in case this relates to #208 (comment). |
gtsiolis
force-pushed
the
des-209-hide-banner-on-login-command
branch
2 times, most recently
from
1749645 to
c8b617c
Compare
gtsiolis
force-pushed
the
des-209-hide-banner-on-login-command
branch
from
c8b617c to
27c207b
Compare
| return styles.Secondary.Render(">") + " " + styles.Warning.Render("Warning:") + " " + e.Text | ||
| case SeveritySecondary: | ||
| return e.Text | ||
| return styles.SecondaryMessage.Render(e.Text) |
Collaborator
There was a problem hiding this comment.
issue: the convention so far is to not do any styling in non-TTY.
What about keeping the TUI in this case but just hide the header, as we do in a few places already:
lstk/internal/ui/run_awsconfig.go
Line 29 in 60b92a0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix two issues with the
logincommand: