Skip to content

Latest typedb driver disables TLS differently#145

Merged
purcell merged 1 commit into
mainfrom
fix-ci-typedb
Jun 19, 2026
Merged

Latest typedb driver disables TLS differently#145
purcell merged 1 commit into
mainfrom
fix-ci-typedb

Conversation

@purcell

@purcell purcell commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

This fixes CI for typedb, which appears to have broken over time as the interface of the upstream driver has changed.

@purcell purcell marked this pull request as ready for review June 18, 2026 15:48
@purcell purcell requested a review from whummer as a code owner June 18, 2026 15:48

@whummer whummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @purcell ! Btw, please feel free to merge such smaller fixes without review from my side, going forward. 🙌 (I know we are in the process of defining PR review guidelines for Engineering more broadly right now, but just wanted to mention :) )

@whummer

whummer commented Jun 18, 2026

Copy link
Copy Markdown
Member

Btw, just noticed that I never merged this PR (which may slightly overlap with some of your fixes): #138 What's the best way to proceed - do you want to take ownership here and cherry-pick any changes from #138 that could be relevant, and then either merge #138 or close it if we no longer need it? 🙏 Please let me know how I can help!

@purcell

purcell commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks. A couple of the changes here are cleaner, e.g. there was no need to install libvirt in that other PR. I'll cherry-pick the remaining changes from there and apply them in a separate PR.

I think that reviews are still required on this repo, and I'm not an admin, otherwise I probably would have merged directly. That's been fixed now so I can apply trivial fixes without review.

@purcell purcell merged commit 9e972bc into main Jun 19, 2026
1 check passed
@purcell purcell deleted the fix-ci-typedb branch June 19, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants