Fix moderation filter checking wrong model in arena side-by-side views#3842
Open
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Open
Fix moderation filter checking wrong model in arena side-by-side views#3842Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Conversation
In both gradio_block_arena_anony.py and gradio_block_arena_vision_named.py, `all_conv_text_right` was reading from `states[0]` instead of `states[1]`, meaning the right-side model's conversation was never checked by the moderation filter. This was already fixed in gradio_block_arena_named.py (commit 34eca62) but missed in these two files. Fixes lm-sys#3794 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all_conv_text_rightread fromstates[0](left model) instead ofstates[1](right model) in two arena filesgradio_block_arena_named.py(commit 34eca62) but missed ingradio_block_arena_anony.pyandgradio_block_arena_vision_named.pyFixes #3794
Changes
fastchat/serve/gradio_block_arena_anony.pyline 310:states[0]→states[1]fastchat/serve/gradio_block_arena_vision_named.pyline 245:states[0]→states[1]Test plan
🤖 Generated with Claude Code