Fix UnboundLocalError in generate_gate when generator yields nothing#3838
Open
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Open
Fix UnboundLocalError in generate_gate when generator yields nothing#3838Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Conversation
Initialize x before the loop to prevent UnboundLocalError if generate_stream_gate yields no items. Fixes lm-sys#3786 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnboundLocalErrorinModelWorker.generate_gate()whengenerate_stream_gate()yields no itemsx = b"{}\0"before the loop so the variable is always defined, returning an empty dict as a safe defaultDetails
In
fastchat/serve/model_worker.py, thegenerate_gatemethod iterates overgenerate_stream_gate(params)and uses the last yielded valuexafter the loop. If the generator yields nothing,xis never assigned, causing anUnboundLocalError.Fixes #3786
Test plan
generate_gateno longer crashes whengenerate_stream_gateyields no items🤖 Generated with Claude Code