[Vulkan][DirectX] Add tests and support for TextureCube and TextureCubeArray - #1476
Open
Icohedron wants to merge 2 commits into
Open
[Vulkan][DirectX] Add tests and support for TextureCube and TextureCubeArray#1476Icohedron wants to merge 2 commits into
Icohedron wants to merge 2 commits into
Conversation
bob80905
reviewed
Aug 25, 2026
bob80905
left a comment
bob80905
left a comment
Contributor
There was a problem hiding this comment.
Looking good, might also suggest a light comment trim.
bob80905
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1134
Fixes #1381
This PR registers TextureCube and TextureCubeArray with the DirectX and Vulkan backends, and adds tests to exercise the types.
Since neither type is currently implemented in Clang (currently in PRs llvm/llvm-project#218520 and llvm/llvm-project#218521), they have been excluded from running with Clang using C preprocessor macros.
Assisted by: Claude Opus 5
Stack created with GitHub Stacks CLI • Give Feedback 💬