Add max and min matrix tests - #1459
Open
kmpeng wants to merge 2 commits into
Open
Conversation
1 task
inbelic
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #816 and #817.
Adds matrix tests for
maxandmintestingfloat,int, anduint. Themaxandmintests use the same input values. Will remove the XFAILs once the Clang implementations are in.Only testing 32-bit types because
float/int/uintexercise all of themax/minops on the DirectX and SPIR-V backends, and those ops behave the same at every bit size.Assisted-by: Claude Opus 4.8