Add InterlockedExchange tests - #1437
Open
bob80905 wants to merge 6 commits into
Open
Conversation
farzonl
reviewed
Aug 21, 2026
| } | ||
| #endif | ||
|
|
||
| #ifdef VK_EXT_SHADER_ATOMIC_FLOAT_EXTENSION_NAME |
Member
There was a problem hiding this comment.
why do we need to do a preprocessor for this?
Contributor
Author
There was a problem hiding this comment.
Not strictly necessary.
This was added to mimic / stay consistent with other preprocessing guards, as seen on line 1590.
However, we use a newer macro elsewhere, unguarded (VK_EXT_mesh_shader).
So this ifdef will always be true assuming the build works.
I'll remove the guards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the InterlockedExchange tests.
It also lights up a feature bit that is necessary for testing floats on groupshared memory using atomic operations.
Fixes #854
Assisted by: Github Copilot