Add matrix tests for isinf() and isnan() - #1397
Open
danbrown-amd wants to merge 5 commits into
Open
Conversation
danbrown-amd
force-pushed
the
isnan_mat
branch
3 times, most recently
from
August 19, 2026 02:45
c100964 to
006f9d4
Compare
This was
linked to
issues
Aug 21, 2026
kmpeng
reviewed
Aug 21, 2026
kmpeng
left a comment
kmpeng
left a comment
Contributor
There was a problem hiding this comment.
From now on, could you please use Github's closing keywords (e.g. closes, resolves, etc.) instead of "addresses" in your PRs so the linked issues are closed upon merge?
Comment on lines
+67
to
+68
| # Bug: https://github.com/llvm/llvm-project/issues/140824 | ||
| # XFAIL: Clang |
Contributor
There was a problem hiding this comment.
Just wondering, is there any way we can avoid hitting this bug with these tests? Or would that require a huge workaround? Kind of unfortunate we can't test the Clang implementation that went in at all because of this bug :\
Collaborator
Author
There was a problem hiding this comment.
I'll look into what it would take to avoid the bug. I saw that it got unassigned...
danbrown-amd
force-pushed
the
isnan_mat
branch
from
August 24, 2026 18:16
006f9d4 to
317ee64
Compare
kmpeng
approved these changes
Aug 24, 2026
Co-authored-by: Kaitlin Peng <hi.kaitlin@gmail.com>
kmpeng
reviewed
Aug 25, 2026
Co-authored-by: Kaitlin Peng <hi.kaitlin@gmail.com>
Collaborator
Author
|
Build is broken: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #810 and #929.