Added WaveOps tests for QuadReadLaneAt#1335
Open
kcloudy0717 wants to merge 3 commits into
Open
Conversation
12 tasks
inbelic
approved these changes
Jul 8, 2026
inbelic
left a comment
inbelic
left a comment
Contributor
There was a problem hiding this comment.
LGTM, are we able to close the issues that are no longer linked as duplicate now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #884.
Note there is a separate testing path between DXIL and SPIRV due to the lane index restriction between the two IRs. DXIL allows lane index to be non-uniform as described in https://github.com/microsoft/DirectXShaderCompiler/wiki/Wave-Intrinsics, whereas SPIRV only allows constant (dynamically uniform after version 1.5, https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#OpGroupNonUniformQuadBroadcast).