[Synth] Refactor CutRewritePattern to return area/delay from match() #9434
+141
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change match() to return std::optional<MatchResult> instead of bool, computing area and delays during matching rather than via separate getArea()/getDelay() queries. Main motivation: Enable AIG/MIG-level rewriting patterns to compute delays dynamically per cut (e.g., SOP-based delays), while tech/LUT mapping patterns can still use cached constant delays efficiently. MatchResult supports both borrowed delays (zero-cost references for constant delays) and owned delays (for dynamically computed values). All existing patterns updated to use cached delays. CutEnumerator now passed to match() and rewrite() for accessing cut information. Non functional change for existing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change match() to return std::optional instead of bool, computing area and delays during matching rather than via separate getArea()/getDelay() queries.
The main motivation is to enable AIG/MIG-level rewriting patterns to compute delays dynamically per cut (e.g., SOP-based delays), while tech/LUT mapping patterns can still use cached constant delays efficiently.
MatchResult supports both borrowed delays (zero-cost references for constant delays) and owned delays (for dynamically computed values).
Non functional change for existing code