Skip to content

Bump LLVM to 26ff16663777fc995e8c6b46fa2433610dab4f64.#9340

Closed
mikeurbach wants to merge 2 commits intomainfrom
mikeurbach/bump-llvm
Closed

Bump LLVM to 26ff16663777fc995e8c6b46fa2433610dab4f64.#9340
mikeurbach wants to merge 2 commits intomainfrom
mikeurbach/bump-llvm

Conversation

@mikeurbach
Copy link
Copy Markdown
Contributor

This appears to be a clean bump.

@mikeurbach
Copy link
Copy Markdown
Contributor Author

I know we are long overdue for an LLVM bump... @uenoku I saw the linked PR, which was then reverted. Do you think the CI fails are related to circt-lsp-server?

@uenoku
Copy link
Copy Markdown
Member

uenoku commented Jan 5, 2026

I debugged a bit more but it turned out lsp unittest was not root cause (https://github.com/llvm/circt/actions/runs/20674012325 is a CI run that disabled lsp unittests entirely and still failed)..

@uenoku
Copy link
Copy Markdown
Member

uenoku commented Jan 6, 2026

https://github.com/llvm/circt/actions/runs/20732951411/job/59524531509

Ok it seems like Dialect/FIRRTL/grand-central.mlir is hanging.

TIMEOUT: CIRCT :: Dialect/FIRRTL/grand-central.mlir (1030 of 1030)
******************** TEST 'CIRCT :: Dialect/FIRRTL/grand-central.mlir' FAILED ********************
Exit Code: -9
Timeout: Reached timeout of 60 seconds

Command Output (stderr):
--
circt-opt --verify-roundtrip -pass-pipeline='builtin.module(firrtl.circuit(firrtl-grand-central,symbol-dce))' -split-input-file /__w/circt/circt/test/Dialect/FIRRTL/grand-central.mlir | /__w/circt/circt/llvm/install/bin/FileCheck /__w/circt/circt/test/Dialect/FIRRTL/grand-central.mlir # RUN: at line 1
+ /__w/circt/circt/llvm/install/bin/FileCheck /__w/circt/circt/test/Dialect/FIRRTL/grand-central.mlir
+ circt-opt --verify-roundtrip '-pass-pipeline=builtin.module(firrtl.circuit(firrtl-grand-central,symbol-dce))' -split-input-file /__w/circt/circt/test/Dialect/FIRRTL/grand-central.mlir

@uenoku uenoku requested a review from teqdruid as a code owner January 6, 2026 02:24
@uenoku
Copy link
Copy Markdown
Member

uenoku commented Jan 6, 2026

It should be good to merge now.

uenoku added a commit that referenced this pull request Jan 7, 2026
By default there is no timeout for tests, but I think it's reasonable to set loose time limit so that we can identify tests with infinite loops more easily (like an issue we saw in #9340). There is no difference in Docker image other than `psutil`.
@jpienaar
Copy link
Copy Markdown
Member

OK if merged? (I was going to start one and then noticed this one so thought I'd ask first)

@seldridge
Copy link
Copy Markdown
Member

I think the right thing to do is re-bump with a commit that includes llvm/llvm-project#174874 and back out the change to disable round tripping.

@jpienaar
Copy link
Copy Markdown
Member

Made #9443 .

@seldridge
Copy link
Copy Markdown
Member

Superseded by github.com//pull/9443.

@seldridge seldridge closed this Jan 14, 2026
@mikeurbach
Copy link
Copy Markdown
Contributor Author

Thanks @jpienaar !

@mikeurbach mikeurbach deleted the mikeurbach/bump-llvm branch February 6, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants