Bump LLVM to 26ff16663777fc995e8c6b46fa2433610dab4f64.#9340
Bump LLVM to 26ff16663777fc995e8c6b46fa2433610dab4f64.#9340mikeurbach wants to merge 2 commits intomainfrom
Conversation
This appears to be a clean bump.
|
I know we are long overdue for an LLVM bump... @uenoku I saw the linked PR, which was then reverted. Do you think the CI fails are related to circt-lsp-server? |
|
I debugged a bit more but it turned out lsp unittest was not root cause (https://github.com/llvm/circt/actions/runs/20674012325 is a CI run that disabled lsp unittests entirely and still failed).. |
|
https://github.com/llvm/circt/actions/runs/20732951411/job/59524531509 Ok it seems like |
|
It should be good to merge now. |
By default there is no timeout for tests, but I think it's reasonable to set loose time limit so that we can identify tests with infinite loops more easily (like an issue we saw in #9340). There is no difference in Docker image other than `psutil`.
|
OK if merged? (I was going to start one and then noticed this one so thought I'd ask first) |
|
I think the right thing to do is re-bump with a commit that includes llvm/llvm-project#174874 and back out the change to disable round tripping. |
|
Made #9443 . |
|
Superseded by github.com//pull/9443. |
|
Thanks @jpienaar ! |
This appears to be a clean bump.