Skip to content

feat: Add additional Tool runtime metrics#4904

Merged
leseb merged 3 commits intollamastack:mainfrom
gyliu513:2604
Mar 10, 2026
Merged

feat: Add additional Tool runtime metrics#4904
leseb merged 3 commits intollamastack:mainfrom
gyliu513:2604

Conversation

@gyliu513
Copy link
Copy Markdown
Contributor

@gyliu513 gyliu513 commented Feb 13, 2026

What does this PR do?

Fixed #2604

Added two metrics for tool runtime:

  • llama_stack.tool_runtime.invocations_total - Counter tracking total invocations
  • llama_stack.tool_runtime.duration_seconds - Histogram of invocation latency

Test Plan

@gyliu513 gyliu513 marked this pull request as draft February 13, 2026 02:10
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 13, 2026
@gyliu513 gyliu513 force-pushed the 2604 branch 2 times, most recently from d4e6368 to 952d009 Compare February 13, 2026 02:13
@gyliu513 gyliu513 changed the title Add additional Tool runtime metrics feat: Add additional Tool runtime metrics Feb 13, 2026
@gyliu513 gyliu513 marked this pull request as ready for review February 16, 2026 20:13
@gyliu513
Copy link
Copy Markdown
Contributor Author

@leseb @cdoern can you help review? Thanks!

Copy link
Copy Markdown
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a doc we need to update with the list of metrics we expose?

@gyliu513
Copy link
Copy Markdown
Contributor Author

do we have a doc we need to update with the list of metrics we expose?

@leseb not yet, that should be a sub task for this epic

Copy link
Copy Markdown
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leseb leseb merged commit f2ad465 into llamastack:main Mar 10, 2026
53 checks passed
@gyliu513 gyliu513 deleted the 2604 branch March 10, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional Tool runtime metrics

2 participants