mark inference.{embeddings,chat_completion,completion} deprecated#248
Closed
mattf wants to merge 1 commit intollamastack:mainfrom
Closed
mark inference.{embeddings,chat_completion,completion} deprecated#248mattf wants to merge 1 commit intollamastack:mainfrom
mattf wants to merge 1 commit intollamastack:mainfrom
Conversation
mattf
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
reluctantfuturist,
vladimirivic and
yanxi0830
as code owners
ashwinb
reviewed
Jun 25, 2025
| extra_body: Body | None = None, | ||
| timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN, | ||
| ) -> ChatCompletionResponse | Stream[ChatCompletionResponseStreamChunk]: | ||
| warnings.warn( |
Contributor
There was a problem hiding this comment.
hm, this is actually auto-generated code. I think we'd need to look into stainless to see if this can be done.
Contributor
Author
There was a problem hiding this comment.
is this something i can do?
Contributor
There was a problem hiding this comment.
@mattf unfortunately not since stainless is controlled by us (meta) right now. we are working to make this be community owned also.
Contributor
|
I think we might be able to get this landed. But could you make the same PR for the https://github.com/llamastack/llama-stack-client-python/ repository? I will archive this repository now. |
Contributor
|
Closing this since these changes need to be generated via the Stainless SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mark inference.{embeddings,chat_completion,completion} deprecated per llamastack/llama-stack#2365
Test Plan
pytest tests/test_deprecated_inference.py