auto-generate entities. this breaks things. manual patching required#197
Open
BlinkyStitt wants to merge 1 commit intomainfrom
Open
auto-generate entities. this breaks things. manual patching required#197BlinkyStitt wants to merge 1 commit intomainfrom
BlinkyStitt wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
after reviewing this, i see that it didn't actually make any changes that we want. I'm going to save undoing these changes (ignoring the version numbers) as a patch. Then we can apply the patch after generating and not have to clean up a lot less by hand next time we add a migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this currently fails to compile because we changed the foreign key index on rpc_accounting_v2 to just be a regular index. The SQL query still works. sea-orm just doesn't see it as a related entitity anymore and so
.inner_join(rpc_key::Entity)fails.I'm not sure the recommended way to fix this. For now we can just stay on the old entities. If we have to migrate before fixing this, the relationship can be put back after the entities are generated.