Skip to content

cleanup(docker): Update comfyui-base to allow specifying alternate entrypoint #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliteprox wants to merge 3 commits into
base: main
Choose a base branch
from
+29 −3
Open

cleanup(docker): Update comfyui-base to allow specifying alternate entrypoint #577

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccdb18e
cleanup(docker): Update comfyui-base to allow specifying alternate en…
eliteprox Dec 23, 2025
28b01c3
fix stray
eliteprox Dec 24, 2025
5caddbb
refactor(docker): remove byoc-entrypoint.sh and update entrypoint in …
eliteprox Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
**/__pycache__
**/*.py[cod]
.pytest_cache/
.mypy_cache/
.ruff_cache/
.cache/
.coverage
.hypothesis/
.benchmarks/
*.log
*.tgz
*.tar.gz
*.zip
dist/
build/
pip-wheel-metadata/
*.egg-info/
node_modules/
.env
.git/
.venv/
Expand Down
8 changes: 5 additions & 3 deletions docker/Dockerfile.base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ RUN conda run -n comfystream --cwd /workspace/comfystream --no-capture-output pi
COPY ./workflows/comfyui/* /workspace/ComfyUI/user/default/workflows/
COPY ./test/example-512x512.png /workspace/ComfyUI/input
COPY ./docker/entrypoint.sh /workspace/comfystream/docker/entrypoint.sh
COPY ./docker/byoc-entrypoint.sh /usr/local/bin/byoc-entrypoint.sh
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The byoc-entrypoint.sh script is copied after the entire source tree is copied at line 85 with "COPY . /workspace/comfystream". This means the script is already available at /workspace/comfystream/docker/byoc-entrypoint.sh, making this redundant COPY operation unnecessary. Consider removing this line or moving it before line 85 if you want to copy it independently of the full source tree.

Copilot uses AI. Check for mistakes.
RUN chmod +x /usr/local/bin/byoc-entrypoint.sh

# Install ComfyUI requirements
RUN conda run -n comfystream --no-capture-output --cwd /workspace/ComfyUI pip install -r requirements.txt --constraint /workspace/comfystream/src/comfystream/scripts/constraints.txt --root-user-action=ignore
Expand Down Expand Up @@ -118,7 +120,7 @@ RUN echo "conda activate comfystream" >> ~/.bashrc

WORKDIR /workspace/comfystream

# Run ComfyStream BYOC server from /workspace/ComfyUI within the comfystream conda env
ENTRYPOINT ["conda", "run", "--no-capture-output", "-n", "comfystream", "--cwd", "/workspace/ComfyUI", "python", "/workspace/comfystream/server/byoc.py"]
# Default args; can be overridden/appended at runtime
# Run ComfyStream BYOC server by default but allow overriding the command
ENTRYPOINT ["/usr/local/bin/byoc-entrypoint.sh"]
# Default args; can be overridden/appended at runtime or replaced entirely
CMD ["--workspace", "/workspace/ComfyUI", "--host", "0.0.0.0", "--port", "8000"]
18 changes: 18 additions & 0 deletions docker/byoc-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
3#!/usr/bin/env bash
Comment thread
eliteprox marked this conversation as resolved.
Outdated

set -e

DEFAULT_CMD=(python /workspace/comfystream/server/byoc.py)

# Allow `--` to separate entrypoint flags from the command
if [[ "${1:-}" == "--" ]]; then
shift
fi

# If no args or first arg is an option, run the BYOC server with default args.
if [[ $# -eq 0 || "$1" == -* ]]; then
set -- "${DEFAULT_CMD[@]}" "$@"
fi

exec conda run --no-capture-output -n comfystream --cwd /workspace/ComfyUI "$@"

Loading