ci: add LIP status consistency check#114
Open
rickstaa wants to merge 2 commits into
Open
Conversation
Adds a check that fails when a LIP's status disagrees between its file frontmatter (LIPs/LIP-N.md) and the README index table, or when a status is unknown, a row/file is orphaned, or a status value has stray whitespace. This is the gate that would have caught the half-updated status in #108. Recommended to enable as a required status check in branch protection. Refs #112. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011c4cuAi1T5yQ7WtCbMp3DW
- actions/checkout v4 -> v7, actions/setup-node v4 -> v6, Node 20 -> 24 (latest stable; no breaking changes for a plain checkout on ubuntu-latest). - Document that the allowed-status set is intentionally hardcoded with LIP-1 as the source of truth. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011c4cuAi1T5yQ7WtCbMp3DW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #112.
Adds a CI check that fails when a LIP's status disagrees between its file frontmatter (
LIPs/LIP-N.md) and the README index table — the exact half-update that slipped through in #108. It also flags unknown statuses, orphaned rows/files, and stray whitespace in astatus:value.scripts/check-lip-status.mjs— zero-dependency Node script..github/workflows/lip-status-check.yml— runs on PRs touching LIPs/README and on push tomaster.Recommend enabling it as a required status check in branch protection.
Note
This PR's own check is expected to be red until #113 merges, because
mastercurrently has 6 pre-existing status mismatches — that red is the gate doing its job. Once #113 lands, rebase this branch and it goes green.