-
Notifications
You must be signed in to change notification settings - Fork 156
Add support for frame level user timestamp #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenosaurus
wants to merge
57
commits into
main
Choose a base branch
from
dc/feature/user_timestamp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d2c9858
add user timestamping feature
chenosaurus 4d4027d
attach timestamp in example
chenosaurus b0d3c04
fix the latency calcs
chenosaurus 90083c3
cleanup display overlays
chenosaurus f84fae3
rename flag
chenosaurus 03083a0
add e2ee options
chenosaurus dd62177
display simulcast state
chenosaurus a742917
Merge branch 'main' into dc/feature/user_timestamp
chenosaurus d1b0d5c
use a mapping of rtp timestamp to user timestamp on subscriber side too
chenosaurus f68b83e
move the subscriber user timestamp handler to internal to clean up API
chenosaurus 22f93d9
remove UserTimestamp store in favor of simple map to track ts
chenosaurus 58eef75
Merge branch 'main' into dc/feature/user_timestamp
chenosaurus 32b7278
use chrono crate instead of custom format func
chenosaurus 63c68aa
remove comment
chenosaurus a60654f
change update to 2hz
chenosaurus 867e295
remove last_user_timestamp
chenosaurus 5a1ba5a
update readme
chenosaurus dde7de6
cargo fmt
chenosaurus eecec0e
remove unused callback reference
chenosaurus aa1cdb6
make the rtp lookup map insertion & removal more robust
chenosaurus 2a52bbe
use new option for payload trailer features to enable timestamping
chenosaurus 38734f4
remove timestamp logs
chenosaurus eea46e1
remove noisy logs
chenosaurus 1c779a2
lint
chenosaurus 6f172c1
update TrackPublishOptions in livekit-ffi
chenosaurus de9cd2b
adding the PayloadTrailerFeatures to the ffi protos
chenosaurus d40b41d
attach parser transformer always
chenosaurus f20a93e
add frame id to trailer
chenosaurus 57a7f74
fix parsing. Explicitly set simulcast fps to 30.
chenosaurus d940542
remove debug outputs
chenosaurus f7120e2
output better encode stats
chenosaurus 91283fa
simplify stats
chenosaurus a8412fb
add timestamp on video frame option
chenosaurus 6ab6250
add timestamp burn mod
chenosaurus 790d254
move to TLV trailer format
chenosaurus 8c2a96f
add changeset & add more details to subscriber example for timing
chenosaurus 86fdd78
actually add changeset
chenosaurus c7ba053
Merge branch 'main' into dc/feature/user_timestamp
chenosaurus 339f886
generated protobuf
github-actions[bot] 10b9220
rename to packet trailer
chenosaurus 716374f
Merge branch 'dc/feature/user_timestamp' of github.com:livekit/rust-s…
chenosaurus 351780f
use packet trailer features for enabling specific trailers
chenosaurus aa99c37
revert local changes
chenosaurus b9cc8f1
Merge branch 'main' into dc/feature/user_timestamp
chenosaurus c3f44e8
add frame ID to ffi
chenosaurus d995159
cargo fmt
chenosaurus 79cabbf
fix typo in changeset
chenosaurus 278c925
update readme
chenosaurus f27d3d5
remove unused crates
chenosaurus 17c076b
add new() to VideoFrame with defaults for frame_id & user_timestamp_u…
chenosaurus 28502fa
update changeset & remove debug logs
chenosaurus 4689d97
fix rendering when packet trailer feature is not populated
chenosaurus 516b338
put frame metadata into FrameMetadata struct
chenosaurus 1f18f0f
update VideoFrame to use FrameMetadata
chenosaurus b311d94
change user_timestamp to u64
chenosaurus 8bc4779
cargo fmt
chenosaurus b6747fa
generated protobuf
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| livekit: minor | ||
| livekit-protocol: minor | ||
| livekit-api: minor | ||
| livekit-wakeword: no changelog additions | ||
| soxr-sys: no changelog additions | ||
| webrtc-sys-build: no changelog additions | ||
| webrtc-sys: minor | ||
| livekit-ffi: minor | ||
| yuv-sys: no changelog additions | ||
| libwebrtc: minor | ||
| imgproc: no changelog additions | ||
| --- | ||
|
|
||
| # Add support for frame level packet trailer | ||
|
|
||
| #890 by @chenosaurus | ||
|
|
||
| - Add support to attach/parse frame level timestamps & frame ID to VideoTracks as a custom payload trailer. | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: I think "no changelog additions" still triggers a release for those packages. You can just remove the lines for unaffected packages.