adding ability to control local video track encode parameters#1136
adding ability to control local video track encode parameters#1136chenosaurus wants to merge 5 commits into
Conversation
ChangesetThe following package versions will be affected by this PR:
|
| } | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| struct SetEncodingLimitsRequest { |
There was a problem hiding this comment.
suggestion: Consider putting common structs in a module and share between the two binaries.
| self.sys_handle | ||
| .set_parameters(parameters.into()) | ||
| .set_parameters(native_parameters) | ||
| .map_err(|e| unsafe { sys_err::ffi::RtcError::from(e.what()).into() }) |
There was a problem hiding this comment.
what do these params mean for simulcast, adaptive streaming, and dynacast ?
There was a problem hiding this comment.
added support for setting encoding config for individual simulcast layers. This will not have any effect on adaptive streaming and dynacast as they only dynamically turn on/off individual layers to be streamed based on subscriber demand.
| const SET_VIDEO_ENCODING_LIMITS_METHOD: &str = "set-video-encoding-limits"; | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| struct SetEncodingLimitsRequest { |
There was a problem hiding this comment.
is this designed to cap this track overall ? or we should consider per encoding / layer limits due to simulcast ?
There was a problem hiding this comment.
This still need a bit of work to support simulcast as currently it would apply the same limits to each layer.
There was a problem hiding this comment.
@xianshijing-lk after thinking about simulcast more, it only makes sense for the encoding limits to control the high layer and for the publisher to automatically generate the medium and low layers.
4 participants
Uh oh!
There was an error while loading. Please reload this page.