Fix AV1 packet trailers#1115
Open
chenosaurus wants to merge 15 commits into
Open
Conversation
Contributor
|
@chenosaurus, is this ready for review? |
Contributor
Author
yea, after I resolve all the conflicts. |
# Conflicts: # examples/local_video/src/publisher.rs # examples/local_video/src/subscriber.rs # examples/local_video/src/video_display.rs # libwebrtc/src/native/video_stream.rs # livekit/src/prelude.rs # livekit/src/room/participant/local_participant.rs # livekit/src/room/track/local_video_track.rs # webrtc-sys/include/livekit/packet_trailer.h # webrtc-sys/src/packet_trailer.cpp
Contributor
ChangesetThe following package versions will be affected by this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fixes AV1 packet trailer delivery when packet trailers are enabled.
Previously, packet trailers were appended as raw bytes at the end of the encoded frame. That works for codecs like VP8, but breaks AV1 because the subscriber-side decoder sees the appended bytes as invalid AV1 bitstream data. This caused AV1 subscribers to fail/loop on recovery behavior when packet trailers were enabled.
What changed
Validation
cargo fmtcargo check -p webrtc-syscargo test -p livekit --features default,__lk-e2e-test --test packet_trailer_test -- --nocapture --test-threads=1--test-pattern --codec av1 --attach-timestamp --attach-frame-id; subscriber decoded AV1 and reported packet trailer features successfully.