Sending device model over ffi for client telemetry#201
Open
MaxHeimbrock wants to merge 4 commits intomainfrom
Open
Sending device model over ffi for client telemetry#201MaxHeimbrock wants to merge 4 commits intomainfrom
MaxHeimbrock wants to merge 4 commits intomainfrom
Conversation
Contributor
Author
This is how it looks like. |
MaxHeimbrock
force-pushed
the
max/claude/device-model
branch
from
e3980e5 to
5fd6128
Compare
ladvoc
approved these changes
Mar 24, 2026
xianshijing-lk
approved these changes
Mar 25, 2026
Contributor
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
one question, lgtm
MaxHeimbrock
force-pushed
the
max/claude/device-model
branch
from
5fd6128 to
fbfa5f0
Compare
MaxHeimbrock
force-pushed
the
max/claude/device-model
branch
from
fbfa5f0 to
d4d0efe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on iOS, Android and MacOS.
Depends on: livekit/rust-sdks#966