Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sweet-planes-open.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'livekit-client': patch
---

Reuse inactive publisher transceivers in RTCEngine to reduce memory growth on republish
42 changes: 42 additions & 0 deletions src/room/RTCEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,11 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
track.codec = opts.videoCodec;
}

const reusedSender = await this.reuseInactivePublisherSender(track.mediaStreamTrack, streams);
if (reusedSender) {
return reusedSender;
}

const transceiverInit: RTCRtpTransceiverInit = { direction: 'sendonly', streams };
if (encodings) {
transceiverInit.sendEncodings = encodings;
Expand All @@ -932,6 +937,15 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
if (!this.pcManager) {
throw new UnexpectedConnectionState('publisher is closed');
}
const reusedSender = await this.reuseInactivePublisherSender(simulcastTrack.mediaStreamTrack);
if (reusedSender) {
if (!opts.videoCodec) {
return;
}
track.setSimulcastTrackSender(opts.videoCodec, reusedSender);
return reusedSender;
}

const transceiverInit: RTCRtpTransceiverInit = { direction: 'sendonly' };
if (encodings) {
transceiverInit.sendEncodings = encodings;
Expand All @@ -948,6 +962,34 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
return transceiver.sender;
}

private async reuseInactivePublisherSender(track: MediaStreamTrack, streams: MediaStream[] = []) {
if (!this.pcManager) {
return;
}

const transceiver = this.pcManager.publisher
.getTransceivers()
.find(
(candidate) =>
candidate.direction === 'inactive' &&
candidate.mid !== null &&
candidate.sender.track === null &&
candidate.receiver.track?.kind === track.kind &&
candidate.sender.transport?.state !== 'closed',
);

if (!transceiver) {
return;
}

transceiver.direction = 'sendonly';
if ('setStreams' in transceiver.sender && streams.length > 0) {
transceiver.sender.setStreams(...streams);
}
await transceiver.sender.replaceTrack(track);
return transceiver.sender;
}

private async createRTCRtpSender(track: MediaStreamTrack) {
if (!this.pcManager) {
throw new UnexpectedConnectionState('publisher is closed');
Expand Down
Loading