Fix subscriber data channel state events reporting the wrong channel - #1172
Merged
Conversation
hiroshihorie
marked this pull request as ready for review
August 11, 2026 09:50
hiroshihorie
requested review from
cloudwebrtc and
xianshijing-lk
as code owners
August 11, 2026 09:50
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
cloudwebrtc
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_onDataChannel registered a nested listener: every state change on a subscriber data channel attached a new listener to the publisher reliable channel and emitted SubscriberDataChannelStateUpdatedEvent from that channel's state instead. So subscriber state changes produced no immediate event, the events that did arrive carried the publisher channel's state (for the lossy label too), and inner listeners accumulated uncancelled for the lifetime of the connection.
Now each subscriber channel emits its own state directly from a single listener, mirroring the publisher-side wiring.
Also initializes the late stateChangeStream field in MockDataChannel, which previously threw LateInitializationError whenever engine code touched it in tests. Regression test verified to fail against the old wiring.
Pre-existing bug surfaced by Devin on the #1170 reformat diff, fixed separately to keep that PR mechanical.