-
Notifications
You must be signed in to change notification settings - Fork 245
Batch dependency bumps (supersedes open dependabot PRs) #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| patch type="changed" "Update dependencies: device_info_plus to 13.x, connectivity_plus 7.3.1, dart_webrtc 1.8.1, synchronized 3.4.1, uuid 4.6.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Example app pins removed, so iOS/macOS example builds can fail on the build machines
The version pins that kept the example app on older releases of two plugins are deleted (
dependency_overridesremoval atexample/pubspec.yaml:28) without any matching update to the build machine's Xcode setup, so the example app can again fail to build on iOS and macOS.Impact: Automated iOS/macOS builds of the sample app may start failing again for the same reason they were pinned in the first place.
Why the pins existed and what changes now
The removed block pinned
connectivity_plus <7.1.0(comment:NWPath.isUltraConstrained) anddevice_info_plus <12.4.0(comment:NSProcessInfo.isiOSAppOnVision) because those newer Apple APIs are not available on the CI runner's Xcode SDK. With the overrides gone, the example resolves through the library constraints:connectivity_plus: ^7.0.0and the wideneddevice_info_plus: '>=12.3.0 <14.0.0'(pubspec.yaml:37,pubspec.yaml:46), i.e. connectivity_plus 7.3.1 and device_info_plus 13.2.0 — exactly the versions the pins avoided.Nothing in this PR raises or pins the Xcode/SDK version used by the
build-for-ios/build-for-macosjobs (.github/workflows/build.yaml:94-150,.github/actions/setup-flutter/action.ymlhas no Xcode step), so if the runner image still ships the older SDK the compile of those plugin pods will fail.The PR description also states these overrides "stay in place", which contradicts the actual change — worth confirming the removal was intended and validated on CI.
Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.