-
Notifications
You must be signed in to change notification settings - Fork 245
chore(deps): bump json_annotation, json_serializable, mockito and build_runner #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ dev_dependencies: | |
| import_sorter: ^4.6.0 | ||
| yaml: ^3.1.2 | ||
| build_runner: ^2.4.13 | ||
| json_serializable: ">=6.9.5 <6.10.0" | ||
| json_serializable: ^6.14.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Change is missing the required release note file No release-note file is added under Repository ruleAGENTS.md ("Releases") states: "Every PR needs a changeset file in Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
| import_sorter: | ||
| comments: false | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Code-generation dependency upgrade drops support for the oldest Dart version the package claims to support
The upper cap that kept the JSON code generator usable on Dart 3.6 is removed (
json_serializable: ^6.14.1atpubspec.yaml:66), while the package still advertises support down to Dart 3.6, so anyone on Dart 3.6–3.8 can no longer install the project's dependencies.Impact: Contributors and CI setups running the minimum supported Dart/Flutter version will fail at dependency resolution instead of being able to build or test.
Version constraint conflict between environment and dev dependencies
pubspec.yaml:26declaressdk: ">=3.6.0 <4.0.0". The previous constraintjson_serializable: ">=6.9.5 <6.10.0"was added deliberately in commit 0733150 ("chore(deps): cap json_serializable for Dart 3.6 support"). json_serializable 6.14.1 requiressdk: ^3.9.0(and pulls analyzer 13 / build_runner 2.15.1, which requires Dart 3.8+ per the release notes in the PR description), so on a Dart 3.6/3.7/3.8 SDKflutter pub getcannot resolve: the locked 6.14.1 is rejected and no version in^6.14.1is compatible.Either restore an upper cap compatible with Dart 3.6, or raise the declared
environment: sdklower bound (and the AGENTS.md "Requires Dart >= 3.6" statement) in the same change.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.