Skip to content

Comments

single_peer_connection = false by default#64

Open
stephen-derosa wants to merge 1 commit intolivekit:mainfrom
stephen-derosa:sderosa/fix-single-peer-connection-default-state
Open

single_peer_connection = false by default#64
stephen-derosa wants to merge 1 commit intolivekit:mainfrom
stephen-derosa:sderosa/fix-single-peer-connection-default-state

Conversation

@stephen-derosa
Copy link

Sets single_peer_connection = false by default to match SFU.

Setting single_peer_connection = true by default mismatches with the default state of the SFU results in only single tracks working.

Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅, we should open a ticket to address the underlying bug

@stephen-derosa
Copy link
Author

LGTM ✅, we should open a ticket to address the underlying bug

what is the underyling bug? Im happy to create one Im just not sure i know the actual effect

@ladvoc
Copy link
Contributor

ladvoc commented Feb 24, 2026

You mentioned with single PC enabled, you can only see one of the two tracks you have published on the subscriber side—is that right?

@stephen-derosa
Copy link
Author

You mentioned with single PC enabled, you can only see one of the two tracks you have published on the subscriber side—is that right?

Close -- the sending participant sends 2 audio and 2 video streams. The receiving participant only gets 1 audio stream.

@ladvoc
Copy link
Contributor

ladvoc commented Feb 24, 2026

Using single PC mode should not affect the ability of a receiving participant to subscribe to multiple tracks. Since disabling single PC fixes the issue, this indicates a bug in the single PC implementation:

@xianshijing-lk
Copy link
Collaborator

Hi @stephen-derosa , good catch. Finding out these issues are the main purpose of turning single PC on by default in C++, lets fix the underline rust issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants