single_peer_connection = false by default#64
single_peer_connection = false by default#64stephen-derosa wants to merge 1 commit intolivekit:mainfrom
Conversation
ladvoc
left a comment
There was a problem hiding this comment.
LGTM ✅, we should open a ticket to address the underlying bug
what is the underyling bug? Im happy to create one Im just not sure i know the actual effect |
|
You mentioned with single PC enabled, you can only see one of the two tracks you have published on the subscriber side—is that right? |
Close -- the sending participant sends 2 audio and 2 video streams. The receiving participant only gets 1 audio stream. |
|
Using single PC mode should not affect the ability of a receiving participant to subscribe to multiple tracks. Since disabling single PC fixes the issue, this indicates a bug in the single PC implementation: |
|
Hi @stephen-derosa , good catch. Finding out these issues are the main purpose of turning single PC on by default in C++, lets fix the underline rust issues. |
Sets single_peer_connection = false by default to match SFU.
Setting single_peer_connection = true by default mismatches with the default state of the SFU results in only single tracks working.