Skip to content

fix: preserve STT EOS timestamp anchor#5928

Open
nightcityblade wants to merge 1 commit into
livekit:mainfrom
nightcityblade:fix-stt-eos-timestamp-anchor
Open

fix: preserve STT EOS timestamp anchor#5928
nightcityblade wants to merge 1 commit into
livekit:mainfrom
nightcityblade:fix-stt-eos-timestamp-anchor

Conversation

@nightcityblade
Copy link
Copy Markdown
Contributor

Summary

  • keep the previous STT end-time anchor when an END_OF_SPEECH event has no timestamp
  • add a regression test for no-VAD STT turn detection preserving the final transcript timestamp

Fixes #5876

Testing

  • uv run pytest tests/test_agent_session.py -k "stt_eos_without_timestamp_preserves_previous_stt_anchor or stt_eos"
  • uv run ruff check livekit-agents/livekit/agents/voice/audio_recognition.py tests/test_agent_session.py
  • uv run ruff format --check livekit-agents/livekit/agents/voice/audio_recognition.py tests/test_agent_session.py

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nightcityblade seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Soniox END_OF_SPEECH lacks timestamp, causing no-VAD end_of_turn_delay under-reporting

2 participants