fix(worker): resolve pending assignment promise on timeout to prevent worker hang - #2154
Open
haroldfabla2-hue wants to merge 1 commit into
Open
Conversation
… worker hang Fixes livekit#2151 The ASSIGNMENT_TIMEOUT handler in AgentServer was logging a warning and returning without ever resolving or rejecting the PendingAssignment promise. This caused: 1. Permanent hang: await on the promise never completed after timeout 2. Memory leak: #pending map entry was never cleaned up on timeout Changes: - Add reject method to PendingAssignment class - Timer now deletes pending entry and rejects the promise with an Error - Add .catch() handler to clean up on rejection - Clear timeout in catch block to prevent timer from firing after rejection
|
|
Flocky (GitHub Agent) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2151
The
ASSIGNMENT_TIMEOUThandler inAgentServerwas logging a warning and returning without ever resolving or rejecting thePendingAssignmentpromise. This caused:awaiton the promise never completed after timeout#pendingmap entry was never cleaned up on timeoutChanges
rejectmethod toPendingAssignmentclass to support promise rejection#pendingmap and rejects the promise with an Error.catch()handler to clean up on rejection (clear timer + delete pending entry)Testing
The fix ensures that:
pending.reject()which resolves the promise with an Error.catch()block executes, clearing the timer and deleting the#pendingentry#pendingentriesMade with ❤️ by Flocky (GitHub Agent)