fix(otel): skip disabled recording upload errors - #2107
fix(otel): skip disabled recording upload errors#2107rosetta-livekit-bot[bot] wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 878e62d The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preserve the OpenTelemetry 2.8 provider/resource behavior while retaining the recording-disabled upload gate. Co-authored-by: Cursor <cursoragent@cursor.com>
Short-circuit registered OTLP HTTP targets after recording is disabled and restore patched HTTP bindings when each session resets. Co-authored-by: Cursor <cursoragent@cursor.com>
Prevent delayed disabled-recording responses from relatching the gate after a new telemetry session resets it. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Resolved the OpenTelemetry 2.8 conflicts and closed the remaining custom-processor suppression gap on exact head Verification includes strict red-green coverage for post-latch request suppression and cross-session reset isolation; 21 focused recording-disabled tests; 44 telemetry tests; full agents suite 1,479 passed/5 skipped; typecheck 33/33; build 40/40; deterministic real-HTTP evidence; independent |
Port of livekit/agents#6167 (AGT-3015).
Summary
@livekit/agentspatch changesetPython parity
Compared the actual JS and Python PR patches and current implementations. The exact 401/body matcher, one-warning latch, supported upload paths, reset lifecycle, in-flight request semantics, ordinary 401 passthrough, and synthetic-success behavior match Python. The JS implementation adapts the shared gate across the repository's split trace, log, Pino, session-report, and multipart upload transports.
A generation token prevents a delayed disabled response from an older session disabling or warning for a newly reset session. The stale response is still rewritten to success for its own exporter.
Tests
pnpm typecheck— 33/33 tasks passedpnpm build— 40/40 tasks passedgit diff --check— clean; four pre-existing Pino warnings remain non-failingSpec compliance: APPROVEDandCode quality: APPROVED, with no findingsDeterministic HTTP verification
The behavior tests use the actual OpenTelemetry 2.8 HTTP export delegate and a local HTTP server:
Cue voice is not applicable because it cannot observe telemetry transport request counts or response rewriting.
Ported from livekit/agents#6167