fix: guard participant task cleanup#1723
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d60cec7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Ported from livekit/agents#5979
Original PR description
JobContext._participant_available()stores participant-entrypoint tasks keyed by (identity, coro) and the done-callback doesself._participant_tasks.pop((p.identity, coro))with no default. When the same identity connects twice in quick succession (normal client reconnect on flaky mobile networks; Cloud later evicts the duplicate withDUPLICATE_IDENTITY), the second connect overwrites the dict entry atjob.py:727. Both done-callbacks then pop the same key: the first wins, the second raises an unhandledKeyErrorinto asyncio's default exception handler.The code already anticipates the overlap but cleanup is not idempotent.