feat(job): expose singlePeerConnection in JobContext.connect#1715
Open
rosetta-livekit-bot[bot] wants to merge 2 commits into
Open
feat(job): expose singlePeerConnection in JobContext.connect#1715rosetta-livekit-bot[bot] wants to merge 2 commits into
rosetta-livekit-bot[bot] wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 055e38a The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
singlePeerConnectionparameter toJobContext.connect@livekit/agentsPort of livekit/agents#5966.
Note
@livekit/rtc-nodedoes not exposesinglePeerConnectionon its publicRoomOptionstype yet, but the underlyingrtc-ffi-bindingsRoomOptionsprotobuf already includessinglePeerConnection. This PR uses an agents-js-local extension ofRoom.connectoptions to bridge that field.Testing
pnpm build:agentspnpm --filter @livekit/agents lint(passes with existing warnings)pnpm --filter @livekit/agents api:check(fails: existing API Extractor limitation on generatedexport * assyntax inagents/dist/index.d.ts)pnpm exec prettier --check agents/src/job.ts .changeset/single-peer-connection.md