Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates GitHub Actions linting and typing checks by removing the standalone typing workflow and replacing multiple linting jobs with a single unified Prek-based lint job.
Changes:
- Replaced multiple linter/type-check jobs in
linting.yamlwith a singlelintjob running Prek hooks. - Removed the dedicated typing workflow (
typing.yaml), intending for typing checks to be covered elsewhere (e.g., Prek).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/linting.yaml | Consolidates multiple linting/type-check steps into one Prek-driven job (plus existing Prettier job). |
| .github/workflows/typing.yaml | Removes separate ty workflow/job for typing checks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 6 6
Lines 907 907
Branches 128 128
=======================================
Hits 906 906
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ook stage execution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies and consolidates the project's GitHub Actions workflows for linting and typing checks. The main change is the removal of multiple separate jobs for different linters and type checkers, replacing them with a single unified job that runs all relevant checks using Prek hooks. This streamlines CI configuration and maintenance.
Workflow consolidation and simplification:
codespell,ruff,prek-hooks,pylint, andyamllintin.github/workflows/linting.yamlwith a singlelintjob that runs all Prek hooks at once. This reduces redundancy and centralizes linting logic. [1] [2].github/workflows/typing.yamlfile, eliminating the separate typing check job (ty). Typing checks are now assumed to be handled via Prek hooks or another unified mechanism.