Fix segfault: Add mandatory 'location' validation in validator and reader#65
Merged
Merged
Conversation
MutableFire
force-pushed
the
fix-missing-location
branch
6 times, most recently
from
ae57f3c to
027c2ac
Compare
MutableFire
force-pushed
the
fix-missing-location
branch
3 times, most recently
from
689cc08 to
a5fb735
Compare
andr-sokolov
approved these changes
Jul 9, 2026
Contributor
|
I think this change should be covered with test |
MutableFire
force-pushed
the
fix-missing-location
branch
8 times, most recently
from
aefff95 to
c5a2091
Compare
Contributor
Author
Done. |
MutableFire
force-pushed
the
fix-missing-location
branch
3 times, most recently
from
9122440 to
c7805c3
Compare
gmusya
requested changes
Jul 14, 2026
|
|
||
| PQclear(res); | ||
|
|
||
| const char* sql_empty_location = |
Contributor
There was a problem hiding this comment.
I think it is better to split this test into three separate tests
| } | ||
|
|
||
| TEST_F(NegativeServer, MissingLocationOption) { | ||
| PGconn* raw_conn = conn_->Ptr(); |
Contributor
There was a problem hiding this comment.
This test should be skipped in Environment::GetTableType() == TestTableType::kExternal case
| if (list_length(options_list) != 1) { | ||
| if (list_length(options_list) == 0) | ||
| ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE), errmsg("missing required option \"location\""), | ||
| errdetail("The TEA foreign data wrapper requires exactly one option: \"location\"."))); |
Contributor
There was a problem hiding this comment.
Can we declare some "The TEA foreign data wrapper requires exactly one option: \"location\"". variable and use it in both branches?
MutableFire
force-pushed
the
fix-missing-location
branch
from
c7805c3 to
7b5f650
Compare
…ssing-location
MutableFire
force-pushed
the
fix-missing-location
branch
from
7b5f650 to
226d8b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix segmentation fault by implementing strict validation for the mandatory
locationoption in both the FDW validator and the internal location reader. Instead of crashing when the option is missing, the invalid table creation is rejected now. When this table has already been created, throw an error on access.