Skip to content

fix(loader): report malformed parameter directives - #677

Merged
cofin merged 2 commits into
mainfrom
fix/print-parse
Aug 4, 2026
Merged

fix(loader): report malformed parameter directives#677
cofin merged 2 commits into
mainfrom
fix/print-parse

Conversation

@cofin

@cofin cofin commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • make malformed -- param: warnings actionable in standard logging
  • report the file, 1-based line number, and malformed directive in both the message and structured fields
  • preserve strict-mode errors and default warn-and-skip behavior

Closes #676

@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.32%. Comparing base (b475727) to head (ee0b103).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   77.34%   77.32%   -0.02%     
==========================================
  Files         476      476              
  Lines       68106    68107       +1     
  Branches     9363     9363              
==========================================
- Hits        52675    52667       -8     
- Misses      12022    12031       +9     
  Partials     3409     3409              
Flag Coverage Δ
integration 60.89% <0.00%> (-0.04%) ⬇️
py3.10 75.64% <100.00%> (-0.01%) ⬇️
py3.11 75.65% <100.00%> (-0.02%) ⬇️
py3.12 75.66% <100.00%> (+<0.01%) ⬆️
py3.13 75.66% <100.00%> (-0.01%) ⬇️
py3.14 76.53% <100.00%> (-0.02%) ⬇️
unit 64.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sqlspec/loader.py 93.67% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin
cofin force-pushed the fix/print-parse branch from 46eb538 to ee0b103 Compare August 4, 2026 15:48
@cofin
cofin merged commit b6b946a into main Aug 4, 2026
11 checks passed
@cofin
cofin deleted the fix/print-parse branch August 4, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(loader): avoid bare sql.parse.param warnings for malformed directives

2 participants