Add VC Arithmetic Simplification#251
Open
rcosta358 wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds VC simplification for arithmetic identity expressions through
VCImplicationchains for when operands are not constants. When a refinement contains simplifiable arithmetic such as neutral elements, zero multiplication, double negation, negated operands, or guarded division/modulo identities, it simplifies the VC node while preserving its origin and the rest of the VC chain.This new simplification pass is done after substitution and folding, with the following simplifications:
x + 0 → x0 + x → xx - 0 → x0 - x → -xx + (-x) → 0(-x) + x → 0x - x → 0-(-x) → xx + (-y) → x - yx - (-y) → x + yx * 1 → x1 * x → xx * 0 → 00 * x → 0x / 1 → x0 / x → 0(ifx != 0)x / x → 1(ifx != 0)x % 1 → 0x % x → 0(ifx != 0)Example
Related Issue
None.
Type of change
Checklist
mvn testpasses locally