layouts: Add tablet and drawing area outlines#989
Draft
whot wants to merge 1 commit into
Draft
Conversation
This makes the svg files more useful by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently incomplete but covers the recent wacom intuos/cintiq tablets and some xp-pen tablets.
This adds an approximation of an outline (SVG:
id="Outline" class="Outline") and a drawing area (SVG:id="DrawingArea" class="DrawingArea"). The goal of both of those is to make the SVG more useful, right now we focus on just the buttons/rings/..., roughly placed where they should be relative to the screen but without any other information about the tablet.This stems directly from the GNOME Settings OSD approach for configuring these buttons but it's insufficient if we ever want to use it in some other setting. Hence - let's add something that makes this an abstraction of the tablet so we can at least visualize it.
We have over 200 layout files so I'm not going for perfect accuracy here. Some devices are decades old and unlikely to be in use, really we only need to care about tablets from the last few years. And I'll leave proportion-perfect drawings to those that have those tablets and care about this.
For backwards compatibility we should probably make both invisible by default but since afaik only GNOME Settings uses that... meh?