Add global TLS verification skip setting#1576
Merged
Merged
Conversation
Adds a new boolean setting in the Advanced settings group that allows users to globally skip TLS certificate verification for all enhanced apps. This is useful for users who have self-signed certificates on their services. When enabled, the Guzzle HTTP client will set 'verify' => false for all API requests made by enhanced apps. Resolves linuxserver/Heimdall-Apps#687
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives #1535 (closed as stale, original work by @jaycollett — his commit authorship is preserved). Addresses linuxserver/Heimdall-Apps#687.
Adds a Skip TLS Verification (for self-signed certificates) boolean to Settings → Advanced. When enabled,
SupportedApps::execute()sets Guzzleverify => false, which covers both enhanced-app live stats and the config Test button (appTest()routes through the same client). Default is off; it never forcesverify => true, so per-app override vars still compose.One change vs the original PR: it used setting id 15, which
default_taghas since taken on 2.x — the setting now uses the next free id, 16. New installs get it from the seeder; existing installs pick it up on the next version bump becauseAppServiceProvider::setupDatabase()re-runsmigrate --seed(idempotent find-or-create per id) — the same mechanism that introduced ids 12–15. The boolean renders automatically on the settings page viaSetting::getEditValueAttribute(), so no view changes are needed.