Add additional rsync options#555
Open
FrostBird347 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #546 ensures hard links are remembered, if a new hardlink is found by rsync before the old unchanged file is, rsync will end up treating the group of hardlinked files as if they had been modified/created.
Even in the worst possible case scenario, where no files were modified but a bunch of new hardlinks were created in locations that rsync found first (and each file only had at most 1 new hardlink), this issue could only cause a snapshot to require the same amount of space as it did prior to #546.
I have not created an issue page for this since #546 hasn't been accepted.
This pull request fixes that potential issue by adding an option (that's off by default) in the settings menu (under misc options) to tell rsync to not use incremental recursion (at the cost of snapshot speed and memory).
It also adds a second option (that's also off by default) to tell rsync to compare file checksums when creating/restoring snapshots, which is useful if the user suspects file corruption has occurred (since bit rot is unlikely to change the file's size or modification date).