keybindings: allow screenshot keys while a menu is open - #13952
Open
rumours86 wants to merge 1 commit into
Open
Conversation
Area/window/clipboard screenshot keys were registered with ActionMode.NORMAL, so pressing e.g. <Shift>Print with any menu or applet popup open did nothing - while the full-screen SCREENSHOT key (ALL) and the volume keys worked fine in the same situation. Capturing the screen with a popup open is a legitimate and common request, and the pickers in js/ui/screenshot.js handle running on top of an existing modal. Register all screenshot media keys with ActionMode.ALL. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Shift+Print (area screenshot) with any menu or applet popup open does nothing: the area/window/clipboard screenshot keys are registered with
ActionMode.NORMAL, so the modal filter swallows them. Meanwhile the full-screenSCREENSHOTkey is alreadyALLand works in the same situation, as do the volume keys — which makes the dead Shift+Print feel like a bug to the user (that's exactly how it was reported to me).Capturing the screen while a popup is open is a legitimate and common request, and the pickers in
js/ui/screenshot.jshandle starting on top of an existing modal (verified live: the picker opens, Escape cancels cleanly, selection completes cleanly).This registers all six screenshot media keys with
ActionMode.ALL.🤖 Generated with Claude Code