Skip to content

notification: Limit min/max height and enable vscroll#13639

Closed
anaximeno wants to merge 1 commit intolinuxmint:masterfrom
anaximeno:notification/set-max-min-height-and-enable-vscroll
Closed

notification: Limit min/max height and enable vscroll#13639
anaximeno wants to merge 1 commit intolinuxmint:masterfrom
anaximeno:notification/set-max-min-height-and-enable-vscroll

Conversation

@anaximeno
Copy link
Contributor

Avoids cases where notifications would grow beyond the monitor screen height.

Before

Captura de ecrã de 2026-03-12 20-49-43

After

image

@github-actions
Copy link

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/notifications@cinnamon.org/applet.js:122

adjustment.connect('changed', Lang.bind(this, function() {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.


Automated pattern check.

@anaximeno anaximeno force-pushed the notification/set-max-min-height-and-enable-vscroll branch from 6807d7a to 8309548 Compare March 13, 2026 05:19
@github-actions
Copy link

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/notifications@cinnamon.org/applet.js:122

adjustment.connect('changed', Lang.bind(this, function() {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.


Automated pattern check.

Disable vfade, looks a bit bad with the default Mint-Y theme in the notification component.
@anaximeno anaximeno force-pushed the notification/set-max-min-height-and-enable-vscroll branch from 8309548 to 5a12fa0 Compare March 13, 2026 05:21
@anaximeno anaximeno closed this Mar 13, 2026
@anaximeno
Copy link
Contributor Author

replaced by #13640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant