Fix SyntaxWarning in GtkSettingsEditor._get_keyfile#13350
Open
leigh123linux wants to merge 1 commit intomasterfrom
Open
Fix SyntaxWarning in GtkSettingsEditor._get_keyfile#13350leigh123linux wants to merge 1 commit intomasterfrom
leigh123linux wants to merge 1 commit intomasterfrom
Conversation
Move return statement out of finally block to eliminate SyntaxWarning. The finally block served no cleanup purpose and has been removed.
Member
Author
|
mtwebster
reviewed
Feb 6, 2026
| pass | ||
| finally: | ||
|
|
||
| return keyfile |
Member
There was a problem hiding this comment.
I think you need to unindent this line - otherwise this method will only ever return None (on error) or fall through and also return nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move return statement out of finally block to eliminate SyntaxWarning.
The finally block served no cleanup purpose and has been removed.