Move mount/unmount interaction and handling to Cinnamon#13145
Move mount/unmount interaction and handling to Cinnamon#13145
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Moving its responsibilities to cinnamon, this will only be needed during 'fallback' mode for now. ref: linuxmint/cinnamon#13145.
Certain aspects of GtkMountOperation are broken under Wayland in Gtk3 and won't be fixed. Fortunately it can also use a dbus interface (org.gtk.MountOperationHandler) if a provider exists. This allows us to: - provide the 'device is in use' popup and showing which application is using it, when trying to eject a device. - provide the password/question dialog when mounting devices that require interaction before mounting. - eliminate a lot of code and translations from placesManager, and make the behavior identical when interacting with a device whether from a file manager or Cinnamon's drives applet. Translations are provided by Gtk, Gvfs instead (as when ejecting a device from a file manager).
This aims to replace cinnamon-settings-daemon's automount manager. It was originally part of Cinnamon but mostly removed early on when Cinnamon was forked, and we've relied on csd-automount. With the implementation of CinnamonMountOperation for handling unmount operations, we can bring in the autorun dialog as well.
- Improve the Dialog list widgets to allow selection, proper pseudo-classes for highlighting. - Use existing login manager for lock/unlock listeners (and make our screensaver set the locked hint finally).
content. Our messages are better presented as left-justified. - Improve list/list-item styling. - Add a temporary dummy dialog for testing.
Best-practices scannerThis is a regex-based check for API usage that can pose security, performance or This check is not perfect will not replace a normal review.Found 3 potential issue(s):
|
This brings in a few more dialogs and replaces csd-automount for mount detection and handling.
ref:
linuxmint/cinnamon-settings-daemon#445