feat(weekly-brief): BFF route, controller, service with mock/live switch by manishdixitlfx · Pull Request #776 · linuxfoundation/lfx-self-serve

manishdixitlfx · 2026-05-24T18:56:21Z

Tracking: LFXV2-1982 (part of Epic LFXV2-1976)

Summary

Express BFF for the WG Weekly Brief: route + controller + service. Switches between mock data (default for local UI iteration) and live committee-service proxy via WEEKLY_BRIEF_BACKEND=live.

What's new

apps/lfx-one/src/server/routes/weekly-brief.route.ts — 3 endpoints: GET current, POST generate, PUT save
apps/lfx-one/src/server/controllers/weekly-brief.controller.ts
apps/lfx-one/src/server/services/weekly-brief.service.ts — mock fixtures + proxy passthrough
apps/lfx-one/.env.example — adds WEEKLY_BRIEF_BACKEND

Notes

404 from upstream on "no draft yet" is normalized to { brief: null, throttle: defaultThrottle() } — matches committee-service's 200/null contract.
429 / 409 propagated as-is so the global error handler surfaces upstream status codes intact.
Touches apps/lfx-one/src/server/server.ts (protected file) — registers the new route only.

Stack

PR 2/4 on lfx-self-serve. Base = PR #775 (shared-interfaces).

Test plan

yarn lint / yarn build green (verified)
Mock mode returns canned brief
Live mode proxies through MicroserviceProxyService

coderabbitai · 2026-05-24T18:56:27Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27b8c5af-cbdd-4377-bbff-3a79172a9cf6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/wg-weekly-brief-bff

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions

PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.

Copilot

Pull request overview

Adds a new Express BFF surface area for the WG Weekly Brief feature, providing committee-scoped endpoints and a service layer that can run in mock mode locally or proxy to committee-service in “live” mode.

Changes:

Introduces weekly-brief Express route + controller wiring for current/generate/save endpoints.
Adds a WeeklyBriefService that serves mock fixtures by default and proxies to LFX_V2_SERVICE when WEEKLY_BRIEF_BACKEND=live.
Documents the new WEEKLY_BRIEF_BACKEND env var in .env.example.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
apps/lfx-one/src/server/services/weekly-brief.service.ts	Implements mock/live switching and upstream proxying for weekly brief operations.
apps/lfx-one/src/server/controllers/weekly-brief.controller.ts	Adds request handlers with logging and param validation for weekly brief endpoints.
apps/lfx-one/src/server/routes/weekly-brief.route.ts	Defines the `/committees/:committeeId/weekly-briefs/*` routes.
apps/lfx-one/src/server/server.ts	Registers the new weekly brief router under `/api/committees`.
apps/lfx-one/.env.example	Adds `WEEKLY_BRIEF_BACKEND` configuration example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Introduce a closed `WeeklyBriefSourceType` union and use it on WeeklyBriefSourceRef.source_type instead of `string` with an inline comment listing the values (per copilot-pull-request-reviewer). Both the BFF and the Angular service consume this type, so widening it to a real union restores type-safety at every call site without runtime cost. Resolves 1 review thread. Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

… switch Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

…vice Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

Address copilot-pull-request-reviewer comments: - apps/lfx-one/src/server/controllers/weekly-brief.controller.ts: * saveBrief now validates req.body via validateSaveBriefBody before handing off to the service. Surfaces ServiceValidationError with per-field reasons on invalid input. Without this, e.g. a string "1" for revision would concatenate ("1" + 1 = "11") in downstream revision math. - apps/lfx-one/src/server/services/weekly-brief.service.ts: * Narrowed the 404 catch to `error instanceof MicroserviceError` instead of loose `error.status` / `error.statusCode` checks. Matches the convention used in cdp.service.ts, impersonation .service.ts, etc. - apps/lfx-one/.env.example: * Moved the WEEKLY_BRIEF_BACKEND comment above the assignment with a note about dotenv inline-comment parsing — the previous form risked producing values like `live # ...` that wouldn't match the strict === 'live' check in code. Resolves 5 review threads (3 unique findings — two pairs were duplicates flagging the same code on different lines). Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

manishdixitlfx · 2026-05-24T21:05:59Z

Review Feedback Addressed

Commit: 501f263

Changes Made (per copilot-pull-request-reviewer)

apps/lfx-one/src/server/controllers/weekly-brief.controller.ts: saveBrief validates req.body via a dedicated helper before calling the service; surfaces ServiceValidationError with per-field reasons. Prevents the string-revision concatenation bug.
apps/lfx-one/src/server/services/weekly-brief.service.ts: narrowed the 404 catch to error instanceof MicroserviceError, matching the convention used in cdp.service.ts and elsewhere.
apps/lfx-one/.env.example: moved the WEEKLY_BRIEF_BACKEND comment above the assignment to avoid dotenv parsing it into the value.

Threads Resolved

5 of 5 unresolved threads addressed in this iteration (3 unique findings; two pairs were duplicates flagging the same code on different lines).

Address copilot-pull-request-reviewer comments: - apps/lfx-one/src/server/controllers/weekly-brief.controller.ts: * saveBrief now validates req.body via validateSaveBriefBody before handing off to the service. Surfaces ServiceValidationError with per-field reasons on invalid input. Without this, e.g. a string "1" for revision would concatenate ("1" + 1 = "11") in downstream revision math. - apps/lfx-one/src/server/services/weekly-brief.service.ts: * Narrowed the 404 catch to `error instanceof MicroserviceError` instead of loose `error.status` / `error.statusCode` checks. Matches the convention used in cdp.service.ts, impersonation .service.ts, etc. - apps/lfx-one/.env.example: * Moved the WEEKLY_BRIEF_BACKEND comment above the assignment with a note about dotenv inline-comment parsing — the previous form risked producing values like `live # ...` that wouldn't match the strict === 'live' check in code. Resolves 5 review threads (3 unique findings — two pairs were duplicates flagging the same code on different lines). Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org> Refs: LFXV2-1982 Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

Copilot AI review requested due to automatic review settings May 24, 2026 18:56

Copilot started reviewing on behalf of manishdixitlfx May 24, 2026 18:56 View session

manishdixitlfx mentioned this pull request May 24, 2026

feat(weekly-brief): Angular frontend service #777

Draft

2 tasks

github-actions Bot reviewed May 24, 2026

View reviewed changes

Copilot AI reviewed May 24, 2026

View reviewed changes

manishdixitlfx added 3 commits May 24, 2026 14:02

feat(weekly-brief): BFF route, controller, and service with mock/live…

520c79e

… switch Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

style(weekly-brief): reorder public methods before private in BFF ser…

fbf6f74

…vice Signed-off-by: Manish Dixit <mdixit@linuxfoundation.org>

manishdixitlfx force-pushed the feat/wg-weekly-brief-bff branch from 666d056 to 501f263 Compare May 24, 2026 21:05

manishdixitlfx force-pushed the feat/wg-weekly-brief-shared-interfaces branch from cc5c4af to 88e4d63 Compare May 24, 2026 22:43

manishdixitlfx force-pushed the feat/wg-weekly-brief-bff branch from 501f263 to a5f4885 Compare May 24, 2026 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(weekly-brief): BFF route, controller, service with mock/live switch#776

feat(weekly-brief): BFF route, controller, service with mock/live switch#776
manishdixitlfx wants to merge 4 commits into
feat/wg-weekly-brief-shared-interfacesfrom
feat/wg-weekly-brief-bff

manishdixitlfx commented May 24, 2026 •

edited by atlassian Bot

Loading

Uh oh!

coderabbitai Bot commented May 24, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot left a comment •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manishdixitlfx commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

manishdixitlfx commented May 24, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What's new

Notes

Stack

Test plan

Uh oh!

coderabbitai Bot commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manishdixitlfx commented May 24, 2026

Review Feedback Addressed

Changes Made (per copilot-pull-request-reviewer)

Threads Resolved

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

manishdixitlfx commented May 24, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented May 24, 2026 •

edited

Loading

github-actions Bot left a comment •

edited

Loading