fix: handle inert lifecycle state in ui - #2112
Open
gaspergrom wants to merge 4 commits into
Open
Conversation
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds frontend support for the backend’s inert lifecycle state.
Changes:
- Adds inert labels, descriptions, and warning styling.
- Adds lifecycle configuration tests.
- Updates collection lifecycle badges.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
frontend/config/trust-score.ts |
Adds inert label and color. |
frontend/config/trust-score.test.ts |
Tests inert and fallback labels. |
frontend/config/health-breakdown-templates.ts |
Adds inert description. |
frontend/config/health-breakdown-templates.test.ts |
Tests lifecycle descriptions. |
frontend/app/components/modules/collection/components/details/collection-lifecycle-badge.vue |
Maps inert to warning styling. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| stable: { label: 'Stable', color: 'bg-accent-500' }, | ||
| declining: { label: 'Declining', color: 'bg-warning-500' }, | ||
| abandoned: { label: 'Abandoned', color: 'bg-negative-500' }, | ||
| inert: { label: 'Inert', color: 'bg-warning-600' }, |
The inert lifecycle color was added to trust-score.ts but never added to tailwind.ts's safelist, so Tailwind's scanner never generated the class and the lifecycle dot rendered invisible in the actual build. Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
joanagmaia
approved these changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
frontend/app/components/modules/collection/components/details/collection-lifecycle-badge.vue:40
- The PR test plan says hovering the lifecycle badge should show the description, but this component only maps the color variation: its template has no tooltip, and both parent usages render it directly. The proposed manual check therefore cannot pass. Please either add the described tooltip behavior or correct the test plan if the description is only intended for the project overview.
inert: 'warning',
Comment on lines
+15
to
+17
| test('should return Unknown for null or undefined lifecycle state', () => { | ||
| const result1 = getLifecycleLabelConfig(null); | ||
| const result2 = getLifecycleLabelConfig(undefined); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inertlifecycle state, but the frontend lacked handlers for it, causing it to render as "Unknown". This PR adds the missing cases totrust-score.ts,health-breakdown-templates.ts, andcollection-lifecycle-badge.vue.inertto use the warning color band (amber), matching the declining state visually.Changes
frontend/config/trust-score.tsinerttolifecycleLabelConfig: label "Inert", colorbg-warning-600frontend/config/health-breakdown-templates.tsinertcase togetLifecycleDescriptionfrontend/app/components/modules/collection/components/details/collection-lifecycle-badge.vueinert: 'warning'to variationsfrontend/config/trust-score.test.tsgetLifecycleLabelConfigwith inert state and edge casesfrontend/config/health-breakdown-templates.test.tsgetLifecycleDescriptionwith all lifecycle statesJIRA
IN-1240 — Inert lifecycle state not handled in UI — renders as Unknown
Deploy order
No cross-repo dependencies. Insights frontend only.
DB migrations
None.
Test plan
health_score_v2Tinybird pipe returnsinertas a valid lifecycle state valueinertstate in staging; confirm badge displays "Inert" with amber colorpnpm testpassespnpm lint:fixandpnpm tsc-checkpass